This commit is contained in:
@@ -8,7 +8,8 @@ import (
|
||||
"net/http"
|
||||
"testing"
|
||||
|
||||
"code.gitea.io/gitea/tests"
|
||||
auth_model "gitea.dev/models/auth"
|
||||
"gitea.dev/tests"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
)
|
||||
@@ -58,3 +59,51 @@ func TestFeedUser(t *testing.T) {
|
||||
})
|
||||
})
|
||||
}
|
||||
|
||||
// TestFeedUserPublicOnlyToken ensures a public-only API token cannot surface a user's
|
||||
// private activity through their profile feed, even when authenticated as the owner.
|
||||
func TestFeedUserPublicOnlyToken(t *testing.T) {
|
||||
defer tests.PrepareTestEnv(t)()
|
||||
|
||||
// user2 has activity on the private repo user2/repo2
|
||||
const privateMarker = "user2/repo2"
|
||||
|
||||
// a normal read:user token authenticated as the owner sees private activity
|
||||
fullToken := getUserToken(t, "user2", auth_model.AccessTokenScopeReadUser)
|
||||
reqFull := NewRequest(t, "GET", "/user2.rss")
|
||||
reqFull.SetBasicAuth("user2", fullToken)
|
||||
respFull := MakeRequest(t, reqFull, http.StatusOK)
|
||||
assert.Contains(t, respFull.Body.String(), privateMarker)
|
||||
|
||||
// a public-only token must not surface the private activity
|
||||
publicOnlyToken := getUserToken(t, "user2", auth_model.AccessTokenScopeReadUser, auth_model.AccessTokenScopePublicOnly)
|
||||
reqPublicOnly := NewRequest(t, "GET", "/user2.rss")
|
||||
reqPublicOnly.SetBasicAuth("user2", publicOnlyToken)
|
||||
respPublicOnly := MakeRequest(t, reqPublicOnly, http.StatusOK)
|
||||
assert.NotContains(t, respPublicOnly.Body.String(), privateMarker)
|
||||
}
|
||||
|
||||
// TestProfileActivityPublicOnlyToken ensures the HTML profile activity tab does not
|
||||
// surface a user's private activity to a public-only API token, mirroring the RSS/Atom
|
||||
// guard. The /{username} route is AllowBasic, so a public-only PAT used as the Basic
|
||||
// password must still be downgraded even for the feed owner.
|
||||
func TestProfileActivityPublicOnlyToken(t *testing.T) {
|
||||
defer tests.PrepareTestEnv(t)()
|
||||
|
||||
// user2 has activity on the private repo user2/repo2
|
||||
const privateMarker = "user2/repo2"
|
||||
|
||||
// a normal read:user token authenticated as the owner sees private activity
|
||||
fullToken := getUserToken(t, "user2", auth_model.AccessTokenScopeReadUser)
|
||||
reqFull := NewRequest(t, "GET", "/user2?tab=activity")
|
||||
reqFull.SetBasicAuth("user2", fullToken)
|
||||
respFull := MakeRequest(t, reqFull, http.StatusOK)
|
||||
assert.Contains(t, respFull.Body.String(), privateMarker)
|
||||
|
||||
// a public-only token must not surface the private activity
|
||||
publicOnlyToken := getUserToken(t, "user2", auth_model.AccessTokenScopeReadUser, auth_model.AccessTokenScopePublicOnly)
|
||||
reqPublicOnly := NewRequest(t, "GET", "/user2?tab=activity")
|
||||
reqPublicOnly.SetBasicAuth("user2", publicOnlyToken)
|
||||
respPublicOnly := MakeRequest(t, reqPublicOnly, http.StatusOK)
|
||||
assert.NotContains(t, respPublicOnly.Body.String(), privateMarker)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user